Summary
The paper proposing a new Transformer-based graph neural network for directed graphs (DAGs) that restricts the receptive field size of self-attention and adds depth-based node embeddings to improve learning from DAGs. The resulted model is more efficient than previous Graph Transformer models and at the same time more effective in different DAG tasks as shown in many experiments.
Strengths
1. The problem of learning from DAGs is interesting and important. Improving Transformers for this problem is a reasonable direction.
2. The introduced improvements are simple, but effective.
3. Computational complexity analysis in Section 3.5 is a nice addition.
4. Experiments are overall convincing.
5. The paper is easy to follow and presented well.
Weaknesses
While I enjoyed reading the paper, the paper needs to address the following weaknesses:
1. The paper is missing related works [A, B], which seem to be doing exactly the same as DAGNN by proposing what they call GatedGNN. Therefore, citing DAGNN but not citing A/B can be misleading for readers.
2. Papers [C, D] are also related and it would be nice to discuss them as well. Given their recent appearance it's not necessary to empirically compare to them (although it would make the paper stronger), but they should be discussed. In particular, [C] is solving the same ogbg-code2 task, but achieves much better performance, can the authors discuss why? [D] is proposing a Transformer-based [40] graph model for DAGs and also add node depth-based PE embeddings similar to those in this submission + degree-based embeddings based on [40] (which could further improve the results in this submission). Given these papers, L122: "to the best of our knowledge, transformers have not been studied particularly in the context of DAGs" should be rephrased.
3. The DAGRA component of the method does not seem to leverage two important sources of information: (1) the direction of edges -- node predecessors and successors are treated equally based on L163-164; (2) the shortest path distance between nodes -- the mask is equal to 0 or −∞ in L203. Even though the DAGPE embeddings can help to recover this information, leveraging (1) and (2) seems very natural and could improve results by better distinguishing certain DAG structures. In related papers using Transformers for undirected/directed graphs, (1) and (2) are leveraged. For example, in [C] the forward and backward edges are treated separately, and in [40], [C], the shortest path distance is used in masking.
3. Section 3.3's conclusion is not very clear. Is this section trying to say that all nodes will eventually communicate with each other if enough layers and/or large k are used? Please elaborate/rephrase.
4. Results on ogbg-code2 in Table 6 are a bit confusing, because at first it looks like DAG+TF/SAT are using DAGPE, but from the text it sounds like DAGPE is not used. I think it would be more clear to report both results, with DAGPE and without it, even if the latter is better so that the Table does not have blank entries.
**Minor issues:**
- "partial order" - wouldn't it be more appropriate to use "topological order" that is often used in DAG context (e.g. https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.dag.topological_sort.html and [A, B])? "partial order" seems to be more relevant to sets.
- In Tables, bolding results per pair makes sense, but baseline's top performance should be highlighted too. Also, the overall top performance across all rows can be underlined (or highlighted in some other way).
- In Fig. 3, it's hard to conclude that DAG+Nodeformer separate classes better, so I don't think this visualization is helpful in the main text.
- All equations should be numbered so that reviewers and readers can refer to them easily.
- L130: "in more important fields than" - it's a quite subjective statement
- L154: "[a] given node’s predecessors"
- L169: "regular transformers (e.g., Eq. 2)" - Eq. 1?
- L168: "still very different" - please elaborate how is it different given that k=∞ is the best
*References:*
- [A] Graph HyperNetworks for Neural Architecture Search. ICLR 2019.
- [B] Parameter Prediction for Unseen Deep Architectures. NeurIPS 2021.
- [C] Can We Scale Transformers to Predict Parameters of Diverse ImageNet Models? ICML 2023.
- [D] Transformers Meet Directed Graphs. ICML 2023.
Rating
6: Weak Accept: Technically solid, moderate-to-high impact paper, with no major concerns with respect to evaluation, resources, reproducibility, ethical considerations.
Limitations
Limitations are discussed, which is appreciated. L344 says that "we found only a limited number of DAG datasets", so one suggestion would be to use a dataset of DAGs introduced in [B].