Weaknesses
Overall, the paper appears to be solid, however, I think the paper lacks (a bit of) clarity. Some concepts (e.g., extrapolating hyperparameters) are insufficiently or too late introduced and other choices such as the training on all data but the previously used subset are insufficiently justified. Similar clarity issues appear for the mathematical notation. Moreover, the language should be revised/improved. However, I believe that those issues can be fixed. For almost all points, I provide a list of remarks, suggestions, and questions below.
### Remarks:
- Section 1.1: Using subsets for hyperparameter tuning specifically for deep learning models (in a non-DP setting) was also recently considered, e.g., in:
- Killamsetty, K., Durga, S., Ramakrishnan, G., De, A., & Iyer, R. (2021, July). Grad-match: Gradient matching based data subset selection for efficient deep model training. In International Conference on Machine Learning (pp. 5464-5474). PMLR.
- Killamsetty, K., Abhishek, G. S., Lnu, A., Ramakrishnan, G., Evfimievski, A., Popa, L., & Iyer, R. (2022). Automata: Gradient based data subset selection for compute-efficient hyper-parameter tuning. Advances in Neural Information Processing Systems, 35, 28721-28733.
- Definition 2: How is $\mathcal{M}$ an output distribution?
- Theorem 4: Consider mentioning/introducing $\gamma$ for completeness.
- line 106: I consider "number of candidate models $K$" is sub-optimally phrased. A hyperparameter can also be the learning rate, which does not change the model, but the optimization/learning of it. Perhaps something like "the number of runs $K$ within the hyperparemeter tuning" is clearer? This related to my first minor remark (lines 4-5).
- Theorem 5: The notation $\mathcal{X}^N$ was used in Papernot and Steinke but the superscript $N$ was not introduced in this paper. Besides, $n$ instead of $N$ was used. Moreover, $\mathcal{Y}$ denotes the outputs in Papernot and Steinke whereas in this paper, $\mathcal{O}$ was used!
- line 128: How is $\mathcal{M}_1$ different from $A$ in Theorem 5? Both are "hyperparameter tuning algorithms".
- line 130: Aren't $\theta_1$ the model *parameters* instead of the model itself? In Equation (2.3), $f$ is the model with parameters $\theta$.
- Equation (3.1): $\mathcal{M}_1(X_1)$ returns a tuple but in Equation (3.1) it is assumed that it only returns the second entry of that tuple. Besides, the output of $\mathcal{M}(X)$ would then be $((\theta_1, t_1), \theta_2)$.
- Theorem 6: The notation $\mathcal{X}^n$ was never introduced. Besides, if a data set $X$ is an element of $\mathcal{X}$, then a single data point $x$ cannot be. Instead, it should be $x$ in curly brackets, no?
- Lemma 9: First, $C$ was used as a scalar within the clipping strategy. Hence, the variable name cannot be used anymore for something else. Second, $\mathcal{M}$ never took $t$ as an argument before. Consider adapting the notation.
### Minor remarks and suggestions:
- lines 4-5, 35-36: I think "where the number of random search samples is randomized itself" could be stated more clearly.
- line 21, 96, 105, 107, 253, 280: however,
- line 34: "provided a" instead of "gave" (there should be an a)
- lines 53, 56, 225: w.r.t. the number
- line 54: "than" instead of "then"
- line 56: In a non-DP
- line 74: curly brackets for sets
- line 85: "As is common in practice,"
- line 87 (and others): Equation (2.2)
- line 90: to have an $L_2$-norm of at most
- Equation (2.3): Consider mentioning $f$ and $\theta$ for completeness. You could also connect $Z_j$ with the noise mentioned in line 90.
- line 95, 106, 171: Wrong citation style (direct instead of indirect, i.e., by Zhu and Wang, (2019)).
- line 97: If you want to gain space you can try adding `\looseness=-1` after "method." which tells $\LaTeX$ to try to fit "method." into the paragraph. Might also work for the caption of Figure 3. It is a neat trick worth knowing.
- line 124: Inconsistent capitalization: Method should be capitalized
- line 129: the method by
- line 134: either use or consider
- Consistency: "dataset" vs "data set" (e.g., lines 131 vs 134)
- line 135: Math (Equation (3.2)) is always a part of a sentence. Hence, use rather a colon instead of a full-stop.
- line 136: , respectively
- line 137: with a standard [...] Theorem 4
- line 142: The number of iterations $T$ appear for the first time. Consider introducing them earlier, i.e., around lines 89-97.
- line 165: Adam is an ICLR paper, not a preprint.
- line 169: the learning rate
- Consistency: "Thm." vs "Theorem" (e.g., lines 173 vs 212)
- line 193-194: methods [...] as functions
- line 194: mechanism DP-SGD is run
- It is slightly confusing to mix "variants 1 and 2" and "(3.1) and (3.2)".
- Figure 1: the three dashed lines between "our method" and "variant" might be confusing in black and white prints since they look like the blue curve. The crossing of lines around $q=0.1$ could be highlighted with an arrow.
- Consistency: $E$ vs E in lines 202-204.
- [Section 4.1 (but also before): It is slightly weird that some lines are missing line numbers.]
- Section 5: Please name briefly at least the data sets and the learning task. Space can be gained be vertically shrinking Figures 2 and 3.
- line 245: on the
- line 247: 1150 and 1278, respectively.
- line 251: Next,
- line 254: typo in hyperparameter
- Figure 2: What about "$6.06 \times$ slower"? Perhaps that is more clear/less confusing.
- Figure 2 caption: Figure 4 (appendix) shows a more detailed version of this figure.
- line 273: e.g. already means for example
- line 276: "question is" or "questions are"
- line 280: remove on
- Tables: Captions go above tables and vertical lines should be avoided, see https://media.neurips.cc/Conferences/NeurIPS2023/Styles/neurips_2023.pdf
### After the Rebuttal:
I have read all other reviews and all rebuttals. Furthermore, I thank the authors for their answers and the additional insights provided in the extra rabuttal pdf. I keep my original score.
Questions
- Q1: What is meant by "extrapolate the hyperparameter values to a larger dataset"? Can you provide an example? It is mentioned multiple times (lines 10, 43, 123, 131, ...) and I think it should be clarified (earlier). If the main example is in lines 140-146, I think it might help to tease it earlier as I was unsure what might be meant by extrapolating. Additionally, is there another example of extrapolation of hyperparameters?
- Q2: Why is $X_1$ being excluded from $X$ in step 4 in line 132? I see the second variant as being meaningful but what is the motivation/intuition/reasoning behind variant 1?
- Q3: Regarding the adjustment of the learning rate (lines 140-146): Didn't van der Veen et al. (2018) consider a change in batch size with a fix data set size? If the same batch size is used for the subsampled data set and the data set, it should not matter, or?
- Q4: I am slightly confused by the difference of $\gamma$ and $q$, i.e., in Theorem 4 (and lines 193-197). My understanding is that $\gamma$ is for the batch and $q$ is for the subset $X_1$ (line 126). Can you clarify the difference between $\gamma$ and $q$?
- Q5: Can you elaborate on how Figure 1 was created? As in, where do the numbers come from and how do the specific choices (title of the subfigures) go into that?
- Q6: Can you elaborate on what is shown in Figures 2 and 3? Is the complete hyperparameter optimization cycle run ten times and the figures show the averaged test accuracies of the final models (i.e., the ten models with the best hyperparameters)? What are the individual dots per line?
- Q7: The choice of $\mu$ is fixed for Figure 2 but quite differs in Figure 3. CIFAR-10 is harder than MNIST but has less "candidate models". How did you come up with those $\mu$ values? Does CIFAR-10 has the smallest $\mu$ because it uses a pre-trained model and all others are trained from scratch?
- Q8: How is the choice of Adam (DP-SGD gradients) justified when the results only hold for DP-SGD? Did IMDB not work with DP-SGD? What was the reason for this choice?
- Q9: Can you provide a table with data set sizes (and dimensionalities) as well as the used subset sizes?
- Q10: Regarding the computational savings it is stated that the number in the plots next to baseline refers to the mean training time of the baseline scaled wrt the minimum of the variants. Can you provide more insight in those computational savings? Is it just the worst performing model on the smallest subset that yielded this saving once? Are your variants sometimes even slower than the baseline? Is there a substantial difference between the variants?