Summary
The submission discusses the optimality (in terms of approximation error) of approximation $(A, b) \rightarrow f(A)b$ with Lanczos' algorithm.
The main result (Theorem 1) states that the Lanczos iteration is "near instance optimal". Near-instance-optimality relates to the optimal reconstruction of $r(A)b$ for rational functions $r$.
Via the triangle inequality, one can deduce similar statements for general $f$ provided $f$ can be approximated well by rational functions.
The submission proves Theorem 1 by repeatedly applying a similar optimality result for $A^{-1} b$ (i.e. $f=1/x$), which is why the final bound comes with scalar $\kappa(A)^q$ where $\kappa$ is the condition number of $A$ and $q$ the order of the denominator of the rational function.
Strengths
The paper provides an interesting perspective on the performance of Lanczos' algorithm for computing matrix functions.
The main strength is clarity, partly because the result is relatively strong and partly because the presentation is easy to follow.
I appreciate the proof sketch in Section 2.1 and the comparison to prior work in Appendix B (especially in B.2, which I was wondering about while reading the other parts of the manuscript).
I also appreciate the code submission.
Overall, I think this is a nice paper.
Weaknesses
The paper's main contribution is Theorem 1: near-instance optimality of Lanczos' method for computing $f(A)b$.
The weaknesses of this result are twofold:
1. The analysis is limited to exact arithmetic. It is well-known that implementations of Lanczos' method in exact versus finite-precision arithmetic may not match. Focussing on exact arithmetic somewhat limits the practical applicability of Theorem 1.
2. The bound in Theorem 1 includes the constant $\kappa(A)^q$. Similar works (including those discussed in Appendix B) achieve smaller constants, and in practical applications, $\kappa(A)$ can be gigantic. Since the largest $\kappa$ in the experiments seems to be $10^6$ (unless I have missed something), it is slightly unclear whether the bounds actually do explain the superiority of Lanczos' algorithm in practice (where $\kappa$ can exceed $10^6$ by a large margin; see, for instance, the condition number of Gaussian process covariance matrices or discretisations of PDEs).
That said, both weaknesses are openly discussed as limitations.
Furthermore, Krylov methods have gained popularity in machine learning in recent years, as evidenced by the growing number of papers/submissions on Lanczos, Arnoldi, CG, GMRES, etc.
Nevertheless, the submission's connection to existing machine learning literature would be strengthened if at least some of the matrix functions mentioned in the introduction would reappear in the experiments.
Questions
What follows is not directly a question, but the submission's format appears to deviate from the Neurips style in two ways:
1. The abstract contains two paragraphs, even though the template states, "The abstract must be limited to one paragraph."
2. It seems that the mathematics font has been changed from the original Neurips template.
I am unsure what Neurips' policy is here. Should these two things be changed?
Limitations
Limitations are acknowledged. (I discuss this under "Weaknesses" above.)