Summary
This paper sheds light on the relationship between three concepts: (a) generalization (b) flatness and (c) explicitly inducing flatness via SAM. The paper identifies that the relationship is nuanced and is based on certain architectural properties of the model.
Specifically, depending on the architecture, there are three possible regimes:
1. A regime where _every flat minimizer generalizes well_ and SAM finds these minimizers.
2. A regime where _there exists flat minimizers that generalize poorly_ but SAM does _not_ find these minimizers.
3. A regime where _there exists flat minimizers that generalize poorly_ and SAM _does_ find these minimizers.
The paper shows that
- Regime (1) happens for 2-layer RELU networks _without_ bias
- Regime (2) happens for 2-layer RELU networks _with_ bias
- Regime (3) happens for 2-layer RELU networks _with_ bias, _with_ a simplified Layer Norm.
Note that in all cases, the existence of a flat solution that generalizes/memorizes is proven theoretically; while the effect of SAM is demonstrated empirically.
Strengths
1. The questions formalized in the paper are novel, and well-formulated.
2. I gained a much clearer understanding of some generally unclear and confusing concepts: (a) flatness, (b) generalization and (c) explicitly inducing flatness. All these ideas are dealt with care and rigor.
3. The introduction is well-written and the chain of arguments are explained clearly. Despite being a theoretical and nuanced paper, I found it extremely easy to follow the arguments in each section. I thoroughly enjoyed reading the paper!
4. Rather than unnecessarily complicate the theory, the authors come up with a reasonably minimal settings of a 2-layer _non-linear_ model and support their arguments with either a formal result or with a rightly-designed empirical result.
5. That there are situations where the flattest solution does not generalize well is surprising from a theoretical point of view.
Weaknesses
I currently do not have any major concerns about this paper. Most of my comments are follow-up questions, which I enumerate in the next section. My most important question --- which may or may not hint at a weakness --- is below:
### Major question
Q1a: Could you be more explicit about any parameter count dependence in the Rademacher complexity term of Thm 3.1 and Lemma 3.1? I am unsure if this is orthogonal to the main point of the result, so I'd also appreciate some clarity on that.
Q1b: On that note, I'd also like to know why this bound would break down upon the introduction of bias into the architecture. Would one of the terms within the Rademacher complexity end up scaling with the number of datapoints?
Questions
1. Def 4.1 for the memorizing solutions appears to be incomplete and can be more formal. First, by _input data_, please clarify that you are referring to the training data. Furthermore, you also require the additional criterion that the activations of the model on _test_ data are all zero --- is this right? If not, the definition appears to be incomplete as even the raw inputs must more or less satisfy the orthogonality assumption with high probability? i.e., when we sample from a high-dimensional hypercube, two samples must more or less be orthogonal. So this alone shouldn't characterize a memorization solution?
2. Could you provide intuition for what the "flattest solution" in Eq 4 satisfies? It seems to require that _the activated top-layer weights have correspondence to the activations themselves_. I don't think Fig 3 captures this specific structure?
3. Do you empirically find that SAM learns a solution whose parameters resemble Eq 4 in any way?
4. The motivation behind the choice of loss function can be made more transparent. In particular, the main loss function used is squared error loss. In the appendix, the authors also use logistic loss _but with label smoothing_. If I am not wrong these choices ensure that the flattest minimizer exists and is unique up to some permutations. However, with pure logistic loss, the flattest minimizer would become ill-defined since there would be many different flat minimizers "at $\infty$"? I believe this is the reason behind a line of work in PAC-Bayes literature that tries to "normalize" flatness in a well-defined way. In other words, this work "sidesteps" this annoying issue; this is okay, as it still helps outline an elegant insight. But this needs to be clearly stated so that readers can put this result in context.
### Minor suggestions
1. I'd suggest making the specific notion of trace-of-hessian-based flatness clear in the abstract and in the beginning of the introduction. Since there are many notions of flatness, it would be good to be upfront about which notion is being discussed here.
2. In the introduction, I'd suggest clarifying that the SAM-related results are purely empirical.
3. Section 4 title seems incorrect. In this regime, SAM finds the _latter_ non-generalizing solution not the former one.
4. Line 167 makes an abrupt reference to a theorem that's not discussed until then.
5. It's not clear until we get to the discussion of SAM as to whether the proof is empirical or not.
6. In Sec 5.1, instead of simply referring to Thm 3.1 and 4.1, I would add a verbal description so that it's easier to follow.
### Summary
Overall, I found this paper to be insightful, rigorous and clear in its message. The community would find this valuable given the confusing nature of literature in flatness.
### Post-rebuttal update
I have increased my score since the authors addressed my response satisfactorily.
**I'd also like to respectfully express my strong disagreement with concerns raised in the other reviews.**
- Regarding "Two-layer network is too simplistic": When a certain truth has not been proven in any setting to begin with, and when someone makes headway by providing the first proof in a simple setting, it is unfair and counter-productive to hold it against them. For without that headway, there is little hope for more general analyses. In fact, IMO proofs in more general settings (like a multi-layered network) get so unwieldy as to become uninsightful. Furthermore, in this scenario, the setting is a 2-layer network which does not reduce to a linear function of its parameters. IMO, the statements in this paper are already highly non-trivial to identify, let alone prove.
- Regarding considering other alternate versions of SAM, this is an interesting reformulation of the problem. Thanks to this work, we can be better posed to answer more important questions. Hence, again I don't want to fault this paper for not proving its elegant theory in various sophisticated versions of SAM. I would share this review's concern had the considered setting been far removed from practice, and promised no tangible way of extending to other situations --- this doesn't seem to be the case here, in my humble opinion.
Rating
8: Strong Accept: Technically strong paper, with novel ideas, excellent impact on at least one area, or high-to-excellent impact on multiple areas, with excellent evaluation, resources, and reproducibility, and no unaddressed ethical considerations.
Confidence
4: You are confident in your assessment, but not absolutely certain. It is unlikely, but not impossible, that you did not understand some parts of the submission or that you are unfamiliar with some pieces of related work.
Limitations
The paper lists reasonable limitations in the conclusion.