Summary
In the present paper the authors study the problem of distributed learning in the presence of adversarial learners (aka Byzantine workers) and hetogeneous data. The paper aims to generalize and improve previous results on homogeneous data, an assumption that is claimed to be very restrictive in practice. For this they introduce a new concept of (G,B) gradient dissimilarity which has the same relation to the more standard G gradient dissimilarity as an affine variance assumptions has to a bounded variance assumption in stochastic optimization.
Under their assumption they first prove that the breakdown point, i.e., the share of Byzantine workers beyond which the optimization breaks down is upper bounded by $\tfrac{1}{2+B^2}$, where previous results only yield the intuitive bound of $\tfrac12$. They also confirm this theoretical observation numerically. Second, they also establish sharp error bounds in the regime below the breakdown point by proving a lower bound as well as an upper bound, attained by robust distributed gradient descent.
Strengths
I find the paper very clear and well written. The theoretical contributions are very interesting and appear to be novel. Furthermore, the experiments illustrate the sharpness of the results. The proofs in the appendix seem to be sound although I have to say that I didn't check all the details in the proof of Theorem 1. I did check the convergence statement of Theorem 2 the proof of which is rather standard.
Weaknesses
I cannot list any significant weaknesses besides the few questions that I have in the next block.
Questions
p.2: Maybe you can make the connection between the G and (G,B) assumptions and bounded / affine variance assumptions in the analysis of SGD.
p.6, last paragraph: can one estimate B here to see whether it is close to $\sqrt{2}$ which would fit to the $\tfrac14$ you observe numerically?
p.7: Definition 4 should be followed by a few examples for $(f, \kappa)$-robust aggregation rules. Please also mention that in the absence of adversaries, one can just average the gradients and gets a $(0,0)$-robust aggregation rule.
p.8: Here you start using nicefrac excessively which, at least for my brain, is very hard to read and process. Maybe you can use or stick to tfrac for inline fractions which you seemed to have used earlier.
p.30: Number of honest workers should just be $n-f$ not $n-f=10$. If I understand this correctly $n=10$ and $f$ ranges from $1$ to $9$.
Rating
8: Strong Accept: Technically strong paper, with novel ideas, excellent impact on at least one area, or high-to-excellent impact on multiple areas, with excellent evaluation, resources, and reproducibility, and no unaddressed ethical considerations.
Confidence
4: You are confident in your assessment, but not absolutely certain. It is unlikely, but not impossible, that you did not understand some parts of the submission or that you are unfamiliar with some pieces of related work.
Limitations
The authors did make the point that probably not all of their results are sharp, e.g., in terms of constants or the slow down factor for linear convergence in the presence of adversaries.
Negative societal impact is not to be expected in my opinion.