Summary
This work introduces MFCL, a method to primarily alleviate the catastrophic forgetting problem that arises in (more realistic) FL settings framed under the continual learning paradigm. In MFCL, the model is split into a generator (only trained on the server side) and a discriminator (only trained by clients). The former is data-free generative model that is trained to output synthetic samples suitable for the task(s) the discriminator is trained (in federation) to perform. This generator is also used by the clients to inject some synthetic training examples into their own local training stages. This component helps counteracting the forgetting problem. The empirical evaluation suggest that MFCL is far superior to other methods.
Strengths
The main strength of this paper is that it studies a far more realistic setting in which FL is used in practice for cross-device settings: clients come and go; data in the clients changes over time (more is added, some might be deleted); and, there is no centralised dataset available on the server. To this problem, MFCL proposes a solution that, although borrowing components and ideas from existing works, have been adapted to the FL setting and they work well.
Other strengths that I have identified:
* The generative model is of a reasonable size (<1M params if my understanding is correct when looking into Table 1 in the Appendix)
* The Authors proposed SuperImageNet dataset.
Weaknesses
The main weaknesses I see in this work are related to lack of clarity in some important point:
* In my view, folks in the FL community might not be familiar with the concept of "task" (common in the CL literature). This means that Sec 3.2 and other parts before might not be so clear. Later in Sec 4 (in line 261 onwards) a clear example of what a _task_ is is presented. Maybe it's worth giving an informal definition earlier?
* The main results (i.e. Figure 5) are not super clear how to interpret. What does it mean "shows the accuracy of the model on the observed classes so far" (line 315)? Is the plot generated at `t=10` (i.e. after all tasks are completed)?
* Following the comment above: wouldn't it be more informative to have "task" on the x-axis and show how test accuracy (or forgetting) changes as time passes? Presenting the results in such way are more common in some recent CL works I've been reading [1] (see for instance Figures 3,4,5 -- no, I'm not an author :) )
* Figure 3: I think it could be improved adding more details and nomenclature introduced in the text otherwise, what toes the right hand side of Fig3.a tell us that we don't know about all generative training schemes out there? Also, is the "aggregate" green box in Fig3.a outputting the discriminator (yellow rhomboid on the right)? (I think so, so how about connecting them?)
[1] https://arxiv.org/abs/2303.11165
Questions
In addition to the questions I ask in the _Weaknesses_ section, I have a few more:
* Maybe include in the Appendix some additional information about the experimental setup: it seems you used PyTorch, as for FL framework I see there are some utility functions from Flower but for the rest I looks you implemented a custom for loop.
* Why not going a step further with `SuperImageNet` and also fix the number of clients it can be divided into? In FL papers are often hard to compare because people use datasets (synthetic ones specially) in vastly different ways. In my opinion if you were to fix how many partitions it contains, it would help easing the reproducibility problem of FL and ensure subsequent papers that use `SyperImageNet` do so under a common setup. What do you think?
* The role of injecting synthetic images during training (on the client side) could be seen as some form of "alignment" mechanism. This has been presented before in FL [1]. Maybe the Authors could comment whether calling this "alignment" is correct and put it in context with other works? (I only suggested the one that comes to mind immediately, but there are more)
* (very minor style comment) wouldn't It be better to have only full page wide figures/tables (like Fig3) instead of half-page ones (like Tab2,3 and Fig 4) ?
[1] https://arxiv.org/abs/2202.05963
Rating
6: Weak Accept: Technically solid, moderate-to-high impact paper, with no major concerns with respect to evaluation, resources, reproducibility, ethical considerations.
Confidence
4: You are confident in your assessment, but not absolutely certain. It is unlikely, but not impossible, that you did not understand some parts of the submission or that you are unfamiliar with some pieces of related work.
Limitations
There are a few limitations that come to mind after reading this paper:
* How does this method extend to other domains beyond image classification? or image-based problems in general? (I'm inclined to suggest the title of this paper to include the "image" or "vision" keyword)
* In the Discussion, the Authors briefly talk about the privacy implications. I agree that synthetic images do not "resemble any specific training example" but this doesn't have to hold to have some privacy leak. As stated in line 61, the generative model "does not cause any extra data leakage from them [the clients]". But there is a data leak on the discriminator part (just like any other FL method that doesn't apply Differentiable Privacy or similar). Could the Authors comment what would be the implications of adding DP to the discriminator on the client side?