Summary
This paper proposes a two-stage editing method based on expert networks, called SCEN, in the “sequential” setting that a sequence of edit requests is presented.
Overall, the proposed two-stage method, the idea of incorporating the FNN value parameters as expert networks with the indexing neurons, is interesting and novel, showing the effectiveness in the experiment settings. A work is a reasonable extension of T-patcher, towards maintaining multiple knowledge neurons and experts.
However, the papers are not very convincing on methods and experiment settings as follows: it is not convincing why two-stage methods are required, so comparing to T-patcher, architectural advantages are not clear. Another problem is that the proposed method seems not to be scalable well, as the number of additional indexing and weight parameters is just increasing monotonically for larger scale of edits. A simple extension of T-patcher which is not in two-stage manner needs to be compared. Additionally, the paper needs to be rewritten, particularly because the method of the first stage is not very clear (how to train FNN’s down projection weight).
Nevertheless, given its positive aspects of the paper, I am currently leaning to the acceptance, while the current decision is likely changed to lower scores.
Reasons to accept
1. The proposed two-stage editing incorporating with the expert networks is interesting and novel, while the value parameters of FNN are considered as parameters of each expert.
2. Experiment results show that the proposed methods are promising, comparing to other various prior methods, using the llama2 models.
Reasons to reject
1. For each edit request, the proposed editing methods monotonically create a new indexing neuron with a weight vector, and need to keep its own FNN’s value parameters. As a result, if N number of sequential edits is provided, we need to keep N indexing neurons associated with their weight vectors as well as N FNN values parameters separately. It is largely questionable whether increasing the number of parameters is scalable in the practical situation. Even edits where their knowledge and topics are very similar will have their own separate indexing neurons and FNN value parameters, causing the method inefficient.
2. In the two-stage method, the actual editing process is performed at the first stage, while an indexing neuron in the second stage just plays of an “indexing role” which turns on or off, depending on the input query. It is not clear why these two stages are necessary. Why the methods are not designed in a unified manner (without two-stages), like T-patcher?
3. In the experiments, a simple extension of T-patcher not in the “two”-stage manner needs to be compared.
4. An important part is how to actually adjust the parameters of an expert, at the first-stage. But, in Section 3.2, this part is not very clear; how to train W_down^t (down projection weight)? which layers have their own expert parameters?
Questions to authors
Please see weaknesses. Below are further comments.
1) Why counterfact dataset is not used, while it is used in most existing methods?
2) The method is expanded to other multi-hop reasoning setting, like effectively working on Mquake dataset?
3) In experiment results, only cases of 200 and 1000 edits are evaluated. How long an editing sequence where the proposed method is scalable well? Assuming that 1M or 100M edits are provided, what are the memory and inference costs in the proposed methods? In such large-scale edit, even applying Eq. (12) that selects the best expert requires non-trivial inference time.