Summary
This work presents a new algorithm, called In-and-Out, for sampling from the uniform distribution over a convex subset $K$ of $R^d$ that comes with stronger guarantees than previous algorithms. The proposed algorithm is an instantiation of the Proximal Sampler (PS), an abstract sampling algorithm which was recently shown to have very strong guarantees (Chen et al., 2022 [27]). The PS was previously considered for sampling from $\propto e^{-f} dx$ given first-order oracle access to $f$, and was typically implemented using a form of rejection sampling; the guarantees in [27] are stated purely in terms of the Poincare Inequality (PI) or Log-Sobolev Inequality (LSI) constant of the target. In the setting of this work, the target is $\propto 1_K$ the uniform distribution on a set $K$ for which we have membership oracle access, and the implementation also uses (another form of) rejection sampling. The guarantees presented in this work follow from the analysis from [27] (§B.2) and a regularity lemma (Lemma 12), from bounds on the PI and LSI constants of uniform distributions known from various recent works (Lemma 9 and §D), and from fine bounds on the failure probability in rejection sampling (§B.3).
Strengths
From the point of view of the problem of sampling convex bodies, the contributions of this paper are outstanding. The results appear much stronger than previously known guarantees (but I am not familiar with the literature on this problem, so I can only trust the authors's discussion of the related work.) It illustrates that the diffusion approach to sampling can yield strong results on a problem where geometric approaches are perhaps more natural.
From the point of view of algorithmic diffusion, this paper is not "just" a piecing together of several known components, as the analysis of the failure probability of the rejection step is not at all obvious. I found the concise rewriting of the analysis of [27] (Part I of §B.2) quite appreciable as well.
Weaknesses
- No application is presented or discussed. Usually for theoretical works such as this one, the value of the contribution lies in the analysis technique, with the hope that it will allow to eventually obtain guarantees for future applications. But the applications that naturally come to my mind are cases which the results of [27] already cover.
Some minor suggestions:
- The relation between Thms 1, 2, 3 is a little bit confusing, as only Thms 2, 3 talk about PI and LSI constants. Perhaps the presentation of the results could be made clearer by moving Lemma 9 to the end of §2, or at least making a reference to it there.
- I would suggest mentioning already in the abstract or the introduction that In-and-Out is an instance of PS. This would be fairer w.r.t. prior work in my opnion.
- The fact that Part I of §B.2 is a restatement of the analysis of [27] should be clarified (the terms "revisit" and "review" currently used on lines 563, 569 are not completely clear).
- On lines 139-141, you mention that the time-reversal SDE has the property that it is also a reversal "pointwise", i.e, conditional on the endpoint. But I did not see where this fact is used, as in §B.2 only the reversal of the heat flow at the PDE level is used.
Questions
- Regarding the first point in "Weaknesses": what are some application cases in machine learning where your work applies?
- Can the In-and-Out algorithm be extended to sampling from a target $\propto e^{-f} 1_K$ where $f$ is smooth on $R^d$ given first-order access to $f$ and membership oracle access to $K$? Specifically the rejection sampling step and its failure probability analysis (since I expect the analysis of the abstract algorithm, PS, is unchanged)
- On line 175, you mention a better query complexity if $K$ is near-isotropic, but Corollary 1 just below is about the exactly-isotropic case. What does line 175 refer to? (Is it Thm 5? if yes it should be mentioned in the main text)
- Out of curiosity: are there ways to rescale a convex body to be near-isotropic, given membership oracle access? This could give a preprocessing step which could improve the query complexity you report.
Limitations
The authors have adequately addressed the limitations.