Summary
This paper presents a PEFT method (mainly for text-to-image tasks) called FouRA. FouRA learns the LoRA projection in the frequency domain. This idea helps solve the problems of data copying and distribution collapse and thus improves the generated image quality. The effectiveness of FouRA is verified on both CV and NLP tasks.
Strengths
1. The paper is well-organized.
2. The introduction of the FouRA method is clear and easy to follow.
3. Among the issues that this article focuses on, adaptive rank selection is an important issue in the field of PEFT.
Weaknesses
First, ranking has nothing to do with importance.
1. Efficiency is an important property that PEFT methods should have. Compared to LoRA, FouRA introduces additional computational operations, where multiple 1D-DCT transform will be involved in Eq.1. For every token, FouRA requires to perform this transform. Will these 1D-DCTs take too much time? Can the authors show the time required for **each training epoch**?
2. Also, for GPU cost, can the authors please report GPU peak memory required **during fine-tuning**? Comparison of both time and GPU cost can follow two fair settings. (a) FouRA and LoRA achieve similar accuracy, (b) FouRA and LoRA have (roughly) the same rank.
3. In my opinion, except for the methods section, the paper is not very easy to follow. The main reason is that the authors attempt to claim too many arguments, but not all problems are fully analyzed and solved. Generally, the three core points of this article are (a) the Fourier low rank adaptation, (b) adapter rank selection strategy and (c) enabling flexible mixure of multiple adapters. The following 4, 5, 6 are my questions about these three points.
4. ***About Fourier.*** First of all, I don't quite understand how to get $\Delta W_{foura}$ from Eq.5, can the authors provide a derivation? For Lemma 4.1, my understanding is that $\Delta W_1$ and $\Delta W_2$ are actually two potential fitting targets, and you can judge the error of LoRA's r-rank approximation by their eigenvalue distributions. In short, these two variables are approximate targets rather than the fine-tuning results of LoRA or FouRA. So what is the specific meaning of the eigenvalues calculated in Figure 4? There should be a simpler and less confusing way to verify the error of the FouRA approximation, such as fitting a random target matrix (see Figure 6 in the Vera[1] paper) or designing some simple classification tasks (see Figure 7 in the FourierFT[2] paper) with your method .
5. ***Adaptive Rank Selection.*** I reserve my opinion on flexibility. Increasing flexibility may not always lead to high generalization, and may even make convergence difficult (the author could provide a comparison of the convergence speed of fine-tuning with and without the gating module). The claim about flexibility (i.e., input dependent selection) is too strong without evidence or reasonable intuitions. On the contrary, the data-agnostic selection paradigm is probably more concise and elegant because we do not need to learn selection strategies on new data sets. If the authors insist on making this claim, then they can show sufficient experimental results, such as data-dependent selection is better than selection that relies only on the model. In addition, it seems that no ablation study results on rank selection were found.
6. ***Multiple Adapters.*** Not sure what the purpose of section 3.5 is. I understand that the PEFT method has many scenarios and therefore has many excellent properties that should be met. However, it seems that many important metrics are not evaluated, such as efficiency, the number of trainable parameters, and the storage memory occupied by the adapter, etc.
7. It is recommended that authors focus their writing on the text-to-image task. Although there are experimental results on GLUE, this does not seem to be sufficient to verify that FouRA is a general PEFT method. If the main claim of the FouRA paper is to propose a PEFT method for text-to-image generation, I personally believe it will be more readable and the contribution will be more prominent.
[1] VERA: VECTOR-BASED RANDOM MATRIX ADAPTATION. ICLR 2024.
[2] Parameter-Efficient Fine-Tuning with Discrete Fourier Transform. ICML 2024.
Questions
In Line 248, is "RoBERTA-Base" a typo? The results in Table 3 are more like the performance of using RoBERTa-Large.
Moreover, can the author provide the code or demo only for reproducing the result (70.6) on the CoLA dataset? It would be cool if one could reproduce this result with FouRA regardless of whether you use base or large RoBERTa models.