Summary
The authors propose a model editing technique motivated by an observed inconsistency between the gradient of target and training nodes' cross-entropy losses. Their proposed method, Gradient Rewiring for Editable Graph Neural Networks (GRE), stores the anchor of the gradients of the training nodes and uses the anchors during editing to preserve performance. Finally, the authors empirically evaluate their proposed method on a collection of real-world datasets.
Strengths
- I believe the problem to be an important practical problem and that the paper is well-motivated.
- The main observation of the paper, i.e., that the gradients of the target and the training nodes are inconsistent, is interesting and novel in the context of Graph Neural Networks.
- The proposed method seems to perform well consistently. The authors have performed a comprehensive empirical evaluation, and I believe the results are solid.
- The authors are overcoming the quadratic problem in the number of model parameters by solving a dual problem with significantly fewer variables.
Weaknesses
- The method requires storing the gradients of the training dataset. This would raise the memory consumption. It would be great if the authors could include a table with the memory requirements for different models.
- There are a lot of writing/grammar issues. In the following, I will give a (non-exhaustive) list of examples of missing articles and text where the writing could generally be improved. This would generally not be a big deal, but in this case, the writing makes the text very hard to follow and comprehend. I would encourage the authors to do a few revision rounds before updating the manuscript. In my personal experience, free tools such as Grammarly also help with identifying weird formulations or grammar mistakes:
- 16-17: the gradient of *the* loss
- Line 21: "interpreting the features and topology of graph data" - *interpreting* is a somewhat unusual way to describe learning representations on graphs; please consider rephrasing.
- Line 42: "(...) intricate editing for GNNs through the lens of landscape." - this phrasing is very confusing; what landscape? I suggest the authors rephrase to something more akin to "through the lens of the loss landscape of the Kullback-Lieber divergence between the initial node features and the final node embeddings" since this seems to be the technique that [[1]] is proposing.
- Line 46: "(...) perspective, and is compatible with existing work" - please consider rephrasing to something similar to "(...) perspective, which is compatible with existing work".
- Line 49: "(...) can lead to a deterioration in the performance *of* the training nodes" -> "(...) can lead to a deterioration in the performance *on* the training nodes" - the performance is of the model on the training nodes
- Line 55: similar, "performance *of* the training nodes" -> "performance *on* the training nodes"
- The caption of Figure 1 is somewhat confusing; please consider rephrasing.
- Line 93-94: Somewhat confusing: "motivation to rewire gradients *of* model editing" or "motivation to rewire gradients *for* model editing"?
- Line 95: "and advanced version (GRE+)" -> "and *an* advanced version (GRE+)"
- Lines 98-99: "we pre-train (...) on (...) datasets" -> "we pre-train (...) on *the* (...) datasets"
- Lines 101-102: please consider rephrasing to something more akin to "we fine-tune the well-trained model using the cross-entropy loss of the target sample via gradient descent"
- Lines 106-108: "we investigate performance degradation from model gradient perspective" -> "we investigate *the* performance degradation from *a* model gradient perspective"; "we further define training loss" -> "we further define *the* training loss"; "where ... is prediction model ... CE is cross-entropy loss" -> "where ... is *a* prediction model ... CE is *the* cross-entropy loss".
- Footnote 3 is very confusing; please consider rephrasing the entire footnote.
- Lines 131-147 are also somewhat confusing and hard to comprehend due to language. Please consider rephrasing all of the paragraphs.
- Line 148: "where gradient for model prediction is defines as" -> "where *the* gradient for *the* model prediction is *defined* as". Also, the inline *\frac* is not aesthetically pleasing, but that is a very minor complaint.
- Line 161: Please consider either removing "*that*": "it is easy to obtain *that* the optimal dual variable v=..." -> "it is easy to obtain the optimal dual variable $v*$=..." or rephrasing to something more akin to "it is easy to see that the optimal dual variable is $v*$=..."
- Please also consider rephrasing the next lines, from 162 to 164.
- Missing commas on line 172: "the training loss for the whole training dataset, after model editing, is on par with (...)"
- Please consider re-phrasing lines 199-200 to something more akin to "We randomly select a node from the validation set on which the well-trained model makes a wrong prediction."
- Both Tables 1 and 2 have results with different decimal precision for the standard deviation. For instance, GraphSAGE/GRE/CORA/DD has a single decimal ($3.36 \pm 0.2$) while GraphSAGE/GRE+/CORA/DD contains two decimals ($0.41\pm 0.07$). Please consider using the same amount of decimals for all of the results. It makes the table more aesthetically pleasing and easier to read.
- "OOM" is mentioned in the caption of Table 1 as being an out-of-memory error, but there are no OOMs in Table 1. However, Table 2 contains OOMs but the caption does not explain what OOM means.
- Please consider increasing the font of the text for both Figures 1 and 2.
- Figure 4, first row, first column: the figure covers half the "N" of "GCN". The plots are also not vertically aligned on the two columns.
Overall, I believe that the proposed method is solid due to the very good empirical results. However, the writing is lacking to a degree that makes the text very hard to follow and comprehend. I would encourage the authors to revise the text significantly, with multiple rounds of proofreading.
Due to concerns about the clarity and writing, I currently recommend rejection. However, I will revise my score if the authors significantly improve the writing during the rebuttal. I think that the overall work could potentially be impactful and useful from a practitioner's perspective.
[1]: https://arxiv.org/pdf/2305.15529